[PATCH] D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp:26
+namespace string_literals{
+string operator""s(const char *, size_t);
+}
----------------
I discovered that this test started to fail when I landed my revert (0d9919d362a7a70b2a7970861d897ecc47ec9e4d) of f2583f3acf596cc545c8c0e3cb28e712f4ebf21b. I "fixed" the test by changing this to `operator""_s` in ba52a10fca6fc7b791894c584233db012def68a5, but I'm not sure if that changes the meaning of the test. Please review that or follow up on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158346/new/

https://reviews.llvm.org/D158346