[clang-tools-extra] ba52a10 - [clang-tidy] Fix test to not depend on D153156, which was reverted

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 18:39:25 PDT 2023


Author: Reid Kleckner
Date: 2023-08-22T18:39:19-07:00
New Revision: ba52a10fca6fc7b791894c584233db012def68a5

URL: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5
DIFF: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5.diff

LOG: [clang-tidy] Fix test to not depend on D153156, which was reverted

This is a quick fix forward to get bots green again.

Added: 
    

Modified: 
    clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
index 592ffc21f41a4f..a7e4977e767455 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp
@@ -23,7 +23,7 @@ template <typename T> struct set {
 }
 
 namespace string_literals{
-string operator""s(const char *, size_t);
+string operator""_s(const char *, size_t);
 }
 
 }
@@ -778,7 +778,7 @@ bool testIgnoredDummyType(const IgnoredDummyType& value) {
 bool testStringLiterals(const std::string& s)
 {
   using namespace std::string_literals;
-  return s == ""s;
+  return s == ""_s;
   // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: the 'empty' method should be used
   // CHECK-FIXES: {{^  }}return s.empty()
 }
@@ -786,5 +786,5 @@ bool testStringLiterals(const std::string& s)
 bool testNotEmptyStringLiterals(const std::string& s)
 {
   using namespace std::string_literals;
-  return s == "foo"s;
+  return s == "foo"_s;
 }


        


More information about the cfe-commits mailing list