[PATCH] D158476: [driver] Search for compatible Android runtime directories

Tue Aug 22 16:02:35 PDT 2023

smeenai added a comment.

In D158476#4608428 <https://reviews.llvm.org/D158476#4608428>, @thakis wrote:

> I think this is a useful feature, for the reasons mentioned on the thread.
>
> Since this is a superset of D115049 <https://reviews.llvm.org/D115049> (... right?), this should probably revert the changes over there?

Wouldn't it break Chrome if I reverted those changes as part of this diff? I was thinking I could land this, Chrome could move over to a versioned dir (assuming that works for it), and then we could undo D115049 <https://reviews.llvm.org/D115049>. I'm happy to make the revert as part of this change if it'll work out for Chrome though.

> Maybe we should dump searched paths in `-v` mode?

As in output all the versioned directories that were found and considered?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158476/new/

https://reviews.llvm.org/D158476