[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 14:34:33 PDT 2023


erichkeane added a comment.

Are there any Sema tests we can add to show that we warn/diagnose/SOMETHING on these?  If someone passes a negative size, we should probably at least do the warning that it was converted/truncated.



================
Comment at: clang/lib/AST/ExprConstant.cpp:9357
       APSInt N;
       if (!EvaluateInteger(E->getArg(2), N, Info))
----------------
Context missing throughout


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158557/new/

https://reviews.llvm.org/D158557



More information about the cfe-commits mailing list