[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

Aditya Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 11:47:55 PDT 2023


hiraditya created this revision.
hiraditya added reviewers: PiotrZSL, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
hiraditya requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

For fat binaries this test fails. https://github.com/llvm/llvm-project/issues/60304


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158534

Files:
  clang-tools-extra/test/clang-tidy/checkers/performance/trivially-destructible.cpp


Index: clang-tools-extra/test/clang-tidy/checkers/performance/trivially-destructible.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/checkers/performance/trivially-destructible.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/performance/trivially-destructible.cpp
@@ -3,6 +3,9 @@
 // RUN: clang-tidy %t.cpp -checks='-*,performance-trivially-destructible' -fix --
 // RUN: clang-tidy %t.cpp -checks='-*,performance-trivially-destructible' -warnings-as-errors='-*,performance-trivially-destructible' --
 
+// For fat binaries this test fails: https://github.com/llvm/llvm-project/issues/60304
+// UNSUPPORTED: system-darwin
+
 struct TriviallyDestructible1 {
   int a;
 };


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158534.552456.patch
Type: text/x-patch
Size: 736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230822/37e31960/attachment.bin>


More information about the cfe-commits mailing list