[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 08:48:37 PDT 2023


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:135
+    }
+    // For refs to member-like decls, report an implicit ref to the container.
+    if (auto *Qual = DRE->getQualifier()) {
----------------
try to write a test case that relies on this :-)


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:320
+           "auto x = ^bar;");
 }
 
----------------
test using enum


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158515/new/

https://reviews.llvm.org/D158515



More information about the cfe-commits mailing list