[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

Kiran Chandramohan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 05:37:06 PDT 2023


kiranchandramohan added a comment.

For our immediate purpose, I think changing the visibility in the Driver to include `flang` is sufficient. After that, we can spend time implementing this properly by refactoring the code to llvm.



================
Comment at: llvm/include/llvm/Frontend/Driver/FramePointer.h:11
+#include "../../../../../clang/include/clang/Driver/Options.h"
+#include "../../../../../clang/lib/Driver/ToolChains/CommonArgs.h"
+#include "llvm/Option/ArgList.h"
----------------
We should not include clang headers in llvm. We also should not refer to clang inside llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158507/new/

https://reviews.llvm.org/D158507



More information about the cfe-commits mailing list