[PATCH] D155858: Add a concept AST node.

[Jens Massberg via Phabricator via cfe-commits]

massberg marked 13 inline comments as done.
massberg added a comment.

I have resolved some of the comments, but I need another round to finish all of the, Thanks to all reviewers so far!



================
Comment at: clang/include/clang/AST/ExprConcepts.h:90
+  // NOTE(massberg): For the first minimal prototype we keep the
+  // following functions to prevent. Later these functions should
+  // be accessed getConceptReference().
----------------
sammccall wrote:
> incomplete comment: "to prevent" what?
> 
> Also FWIW I don't think *all* uses should be migrated, e.g. `getNamedConcept()` is fundamental enough to be exposed here even if it's implemented via ConceptReference.
I have updated the FIXME.


================
Comment at: clang/include/clang/AST/TypeLoc.h:2198
+      return getConceptLoc()->getTemplateArgsAsWritten()->getTemplateArgs()[i];
+    // FIXME: Check why we still need this fallback in case that there is no
+    // ConceptLoc.
----------------
hokein wrote:
> which kind of tests were broken if we remove this?
This is fixed now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155858/new/

https://reviews.llvm.org/D155858