[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 17:16:09 PDT 2023


MaskRay added a comment.

In D158461#4605084 <https://reviews.llvm.org/D158461#4605084>, @brad wrote:

> Isn't there more than this to do a full proper removal?
>
> Looking around it looks like the Ananas and Contiki support can be removed. Ananas used
> to use Clang but switched back to GCC and the bits there are not maintained. The Contiki
> support never went anywhere.

I agree that Contiki should be removed. The code doesn't even constitute a partial port. It just enables safestack, but this doesn't really justify adding a new ToolChain.

For Ananas, it looks like the author is quite responsive (D124729 <https://reviews.llvm.org/D124729>). But indeed, I don't know whether it is still working.
It looks like Ananas switched from `crt0.o` to `crt1.o` but the code still uses `crt1.o`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158461/new/

https://reviews.llvm.org/D158461



More information about the cfe-commits mailing list