[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 11:35:11 PDT 2023


shafik added inline comments.


================
Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:140
+        D0->getASTContext(), D1->getASTContext(), NonEquivalentDecls01,
+        StructuralEquivalenceKind::Default, false, false, false,
+        IgnoreTemplateParmDepth);
----------------
See [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html) for details of this format. 

We use this everywhere we have literals without clear meaning being used as arguments. 


================
Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:144
+        D1->getASTContext(), D0->getASTContext(), NonEquivalentDecls10,
+        StructuralEquivalenceKind::Default, false, false, false,
+        IgnoreTemplateParmDepth);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156693/new/

https://reviews.llvm.org/D156693



More information about the cfe-commits mailing list