[PATCH] D158439: [Lex] Preambles should contain the global module fragment.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 21 09:58:04 PDT 2023
sammccall created this revision.
sammccall added a reviewer: ChuanqiXu.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
For applications like clangd, the preamble remains an important optimization
when editing a module definition. The global module fragment is a good fit for
it as it by definition contains only preprocessor directives.
Before this patch, we would terminate the preamble immediately at the "module"
keyword.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158439
Files:
clang-tools-extra/clangd/unittests/ModulesTests.cpp
clang/lib/Lex/Lexer.cpp
clang/unittests/Lex/CMakeLists.txt
clang/unittests/Lex/LexerTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158439.552063.patch
Type: text/x-patch
Size: 4101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230821/91bf8782/attachment.bin>
More information about the cfe-commits
mailing list