[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

PoYao Chang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 09:44:18 PDT 2023


rZhBoYao added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:1994-2009
   if (!isAsciiIdentifierStart(C)) {
     if (C == '\\' && tryConsumeIdentifierUCN(CurPtr, Size, Result))
       Consumed = true;
     else if (!isASCII(C) && tryConsumeIdentifierUTF8Char(CurPtr))
       Consumed = true;
     else
       return CurPtr;
----------------
cor3ntin wrote:
> I missed that in the previous review, is the FIX-IT here still relevant?
Yes, I also put back the fixit test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158372/new/

https://reviews.llvm.org/D158372



More information about the cfe-commits mailing list