[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added inline comments.


================
Comment at: clang/test/CodeGen/mrtd.c:2
+// RUN: %clang_cc1 -mrtd -triple i386-unknown-unknown -std=c89 -emit-llvm -o - %s 2>&1 | FileCheck --check-prefixes=CHECK,X86 %s
+// RUN: %clang_cc1 -mrtd -triple m68k-unknown-unknown -std=c89 -emit-llvm -o - %s 2>&1 | FileCheck --check-prefixes=CHECK,M68k %s
 
----------------
Capitalise CHECK prefixes


================
Comment at: clang/test/CodeGen/mrtd.c:10
+// X86: call x86_stdcallcc i32 @bar(
+#ifndef mc68000
   bar(arg);
----------------
Uh, this shouldn't be defined in ISO C; GCC's using builtin_define_std, so you should only get `__mc68000` and `__mc68000__` for ISO C, i.e. using `DefineStd("mc68000")` in libClangBasic and let it add the underscored variants needed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149867/new/

https://reviews.llvm.org/D149867