[PATCH] D158367: [AMDGPU] Add target feature gds/gws to clang

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 08:09:51 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/TargetParser/TargetParser.cpp:289
       Features["image-insts"] = true;
+      Features["gds"] = true;
+      Features["gws"] = true;
----------------
yaxunl wrote:
> arsenm wrote:
> > Gds feature is unused 
> I am thinking to keep it in case we need it for newly added builtins or want to diagnose ops requires gds.
But it's easy to add back in if and when that happens


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158367/new/

https://reviews.llvm.org/D158367



More information about the cfe-commits mailing list