[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 03:49:07 PDT 2023


dang added inline comments.


================
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182-189
   DocComment Comment;
   if (auto *RawComment =
-          getDerivedExtractAPIVisitor().fetchRawCommentForDecl(Decl))
-    Comment = RawComment->getFormattedLines(Context.getSourceManager(),
-                                            Context.getDiagnostics());
+          getDerivedExtractAPIVisitor().fetchRawCommentForDecl(Decl)) {
+    auto RawCommentVec = RawComment->getFormattedLines(
+        Context.getSourceManager(), Context.getDiagnostics());
+    std::copy(RawCommentVec.begin(), RawCommentVec.end(),
+              std::back_inserter(Comment));
----------------
Can you refactor this code to construct the DocComment into it's own function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157810/new/

https://reviews.llvm.org/D157810



More information about the cfe-commits mailing list