[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 03:03:40 PDT 2023


v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.

This change looks reasonable to me.



================
Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:74
+// expected-error at -1 2 {{'Inner' is a private member of 'PR13642'}}
+
 // Deduction guide
----------------
Hahnfeld wrote:
> v.g.vassilev wrote:
> > Could we move the diagnostic-producing cases in a separate file?
> We could, but I'm actually not a big fan because it moves the expected failing test away from the related disambiguation tests above...
Okay, fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157838/new/

https://reviews.llvm.org/D157838



More information about the cfe-commits mailing list