[PATCH] D158378: [Driver] move Minix header search path management to the driver

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D158378#4602375 <https://reviews.llvm.org/D158378#4602375>, @brad wrote:

> In D158378#4602289 <https://reviews.llvm.org/D158378#4602289>, @MaskRay wrote:
>
>> Thank you for driving the migration!
>>
>>   case llvm::Triple::Minix:
>>     AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3",
>>                                 "", "", "", triple);
>>
>> The GCC 4.4.3 thing is from 3e2ee147d0ddb23592b2ec8294381b5e1801cc62 (2010). https://github.com/Stichting-MINIX-Research-Foundation/minix and https://git.minix3.org/index.cgi?p=minix.git haven't had any commit since 2018.
>> We haven't seen any actual Minix driver changes for many years. I think it unlikely works and perhaps we should remove Minix driver support.
>
> Ya, I should have noticed that. I had heard years ago that Minix had switched to Clang. I installed the latest in a VM and it does come with Clang. Clang 3.6.

Thanks. 3.6 is so old. Given many things like `CompilerRT-Generic` that unlikely works, I think it's better to remove `Minix.cpp`.
If the Minix community makes efforts to add back llvm-project support, starting from scratch with proper testing is likely better than the current nearly-untested state...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158378/new/

https://reviews.llvm.org/D158378