[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

[Jianjian Guan via Phabricator via cfe-commits]

jacquesguan marked an inline comment as done.
jacquesguan added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:14906
+    // specified
+    if (S.Context.areCompatibleRVVTypes(QualType(OriginalTarget, 0),
+                                        QualType(Source, 0)) ||
----------------
craig.topper wrote:
> Why do we need this, but SVE doesn't?
Merged with the former sve function.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:12294
 
+  if ((LHSBuiltinTy && LHSBuiltinTy->isSVEBool()) ||
+      (RHSBuiltinTy && RHSBuiltinTy->isSVEBool())) {
----------------
craig.topper wrote:
> This code looks identical to the code above it.
Removed.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:16322
       break;
-    else if (resultType->isSveVLSBuiltinType()) // SVE vectors allow + and -
+    else if (resultType->isVLSBuiltinType()) // SVE vectors allow + and -
       break;
----------------
craig.topper wrote:
> Update "SVE" to mention "RVV" too?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158259/new/

https://reviews.llvm.org/D158259