[clang] 960881a - clang: Make rewrite-includes-macros.cpp runnable on non-Win

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 19 07:47:51 PDT 2023


Author: Nico Weber
Date: 2023-08-19T10:47:37-04:00
New Revision: 960881a7f32abc50fd0e5a349a9981437eba221a

URL: https://github.com/llvm/llvm-project/commit/960881a7f32abc50fd0e5a349a9981437eba221a
DIFF: https://github.com/llvm/llvm-project/commit/960881a7f32abc50fd0e5a349a9981437eba221a.diff

LOG: clang: Make rewrite-includes-macros.cpp runnable on non-Win

As far as I can tell, there's nothing Windows-specific about the
test and it passes fine on other platforms.

I found this test when running

    rg clang_cl clang/test | rg '%s' | rg -v -- ' -- ' | rg -v not

after 547ee1c81fceaabcb to see if other tests were missing `--`
before `%s` in `%clang_cl` invocations. This was the only one.
Since it used to run only on Windows, it wasn't needed, but as far
as I can tell there's no reason to run it only on Windows.

Differential Revision: https://reviews.llvm.org/D158279

Added: 
    

Modified: 
    clang/test/Frontend/rewrite-includes-macros.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/Frontend/rewrite-includes-macros.cpp b/clang/test/Frontend/rewrite-includes-macros.cpp
index 4a2de546d45546..1c2bfd440342fe 100644
--- a/clang/test/Frontend/rewrite-includes-macros.cpp
+++ b/clang/test/Frontend/rewrite-includes-macros.cpp
@@ -1,7 +1,8 @@
-// REQUIRES: system-windows
-// RUN: %clang_cl /E -Xclang -frewrite-includes %s | %clang_cl /c -Xclang -verify /Tp -
+// RUN: %clang_cl /E -Xclang -frewrite-includes -- %s | %clang_cl /c -Xclang -verify /Tp -
 // expected-no-diagnostics
 
+// This test uses dos-style \r\n line endings.
+// Make sure your editor doesn't rewrite them to unix-style \n line endings.
 int foo();
 int bar();
 #define HELLO \


        


More information about the cfe-commits mailing list