[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:508
+  // Only one of Callee or ProtoTypeLoc is set.
+  const FunctionDecl *Callee = nullptr;
+  FunctionProtoTypeLoc ProtoTypeLoc;
----------------
sammccall wrote:
> Calling this "callee" confuses me a bit - originally the callee was an expr and always present, so this must be a different idea: `CalleeDecl`?.
> 
> However I also think this struct has an unneccesarily broad scope: we're not really gaining anything by bundling `Args` into it rather than continuing to pass that as a separate param.
> This suggests:
> 
> ```
> struct Callee {
>   Decl *Declaration;
>   FunctionProtoTypeLoc Loc;
> };
> ```
Good point, updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158249/new/

https://reviews.llvm.org/D158249