[clang-tools-extra] 3e69886 - [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 20:03:10 PDT 2023


Author: Nathan Ridge
Date: 2023-08-18T23:02:48-04:00
New Revision: 3e69886dd012fb446936760f0946db4df5223c48

URL: https://github.com/llvm/llvm-project/commit/3e69886dd012fb446936760f0946db4df5223c48
DIFF: https://github.com/llvm/llvm-project/commit/3e69886dd012fb446936760f0946db4df5223c48.diff

LOG: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

Plus bonus typo fix

Differential Revision: https://reviews.llvm.org/D158248

Added: 
    

Modified: 
    clang-tools-extra/clangd/InlayHints.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/InlayHints.cpp b/clang-tools-extra/clangd/InlayHints.cpp
index 1962aa51aef419..eaefe0850f9cff 100644
--- a/clang-tools-extra/clangd/InlayHints.cpp
+++ b/clang-tools-extra/clangd/InlayHints.cpp
@@ -273,7 +273,7 @@ std::string summarizeExpr(const Expr *E) {
       return getSimpleName(E->getMember()).str();
     }
     std::string
-    VisitDependentScopeMemberExpr(const DependentScopeDeclRefExpr *E) {
+    VisitDependentScopeDeclRefExpr(const DependentScopeDeclRefExpr *E) {
       return getSimpleName(E->getDeclName()).str();
     }
     std::string VisitCXXFunctionalCastExpr(const CXXFunctionalCastExpr *E) {
@@ -534,7 +534,7 @@ class InlayHintVisitor : public RecursiveASTVisitor<InlayHintVisitor> {
 
     // Do not show parameter hints for operator calls written using operator
     // syntax or user-defined literals. (Among other reasons, the resulting
-    // hints can look awkard, e.g. the expression can itself be a function
+    // hints can look awkward, e.g. the expression can itself be a function
     // argument and then we'd get two hints side by side).
     if (isa<CXXOperatorCallExpr>(E) || isa<UserDefinedLiteral>(E))
       return true;


        


More information about the cfe-commits mailing list