[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

[Artem Labazov via Phabricator via cfe-commits]

artem added inline comments.


================
Comment at: clang/test/ubsan/TestCases/Misc/abs.cpp:1
+// REQUIRES: arch=x86_64
+//
----------------
MaskRay wrote:
> Did you mean compiler-rt/ instead of clang/?
> 
> `// REQUIRES: arch=x86_64` is legacy style.
> 
> New style uses `// REQUIRES: target={{x86_64.*}}`
> 
> Actually, this test should be generic and we should remove REQUIRES.
I think that Aaron has moved the file when committed to the main branch. Anyway, moved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156821/new/

https://reviews.llvm.org/D156821