[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

[Jordan Rupprecht via Phabricator via cfe-commits]

rupprecht added a comment.

The other common breakage I'm seeing is code that hasn't yet migrated from the "PRI" format macros, of which there's an example in LLVM itself: https://github.com/llvm/llvm-project/blob/6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4/clang/test/SemaCXX/cxx11-compat.cpp#L38

e.g.: https://godbolt.org/z/v3boc9E6T

> IMHO, people should stop using -Wno-reserved-user-defined-literal and exploiting the addition of a whitespace to mingle pre-c++11 and post-c++11 code.

I mostly agree with this, at least the spirit of it, but do we usually remove the `-Wno` ability to suppress a common error because we don't like it? (Or justify it post-facto if we accidentally did that?) If removing this is important for some other aspect of clang development, it would be nice to have notice ahead of time that this option will go away. I guess +1 to what James said.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153156/new/

https://reviews.llvm.org/D153156