[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

[Han Shen via Phabricator via cfe-commits]

shenhan added inline comments.


================
Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1
+// REQUIRES: system-linux
+// REQUIRES: x86-registered-target
----------------
MaskRay wrote:
> Any reason `system-linux` is needed?
Deleted. Also deleted "REQUIRES: system-linux" from "fsplit-machine-functions-with-cuda-nvptx.c".


================
Comment at: clang/test/CodeGen/fsplit-machine-functions.c:2
+// REQUIRES: system-linux
+// REQUIRES: x86-registered-target
+// REQUIRES: arm-registered-target
----------------
MaskRay wrote:
> We usually place x86 tests under CodeGen/X86 and arm tests under CodeGen/ARM
I can moved the X86 cases to clang/test/CodeGen/X86, but there is no clang/test/CodeGen/Arm or similar, shall I create "clang/test/CodeGen/Arm" instead? 


================
Comment at: clang/test/Driver/fsplit-machine-functions.c:1
-// REQUIRES: arm-registered-target
+// REQUIRES: x86-registered-target
 
----------------
MaskRay wrote:
> If you only use `-###`, `// REQUIRES: x86-registered-target` is unneeded.
Ah, yes. Deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158231/new/

https://reviews.llvm.org/D158231