[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 18 11:21:08 PDT 2023
probinson added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:423
+ if (!CSInfo) {
+ SmallString<64> Checksum;
+ std::optional<llvm::DIFile::ChecksumKind> CSKind =
----------------
In the final commit, `Checksum` is outside the `if` so that its lifetime persists to the end of the function (specifically, past the `createFile` call). `CSInfo` holds a StringRef to this string, not the string itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156571/new/
https://reviews.llvm.org/D156571
More information about the cfe-commits
mailing list