[clang] 89053e4 - [flang][driver] Partial revert of D157837

Andrzej Warzynski via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 08:51:48 PDT 2023


Author: Andrzej Warzynski
Date: 2023-08-18T15:51:18Z
New Revision: 89053e49590302c0a704d1af46ee263a5c882df6

URL: https://github.com/llvm/llvm-project/commit/89053e49590302c0a704d1af46ee263a5c882df6
DIFF: https://github.com/llvm/llvm-project/commit/89053e49590302c0a704d1af46ee263a5c882df6.diff

LOG: [flang][driver] Partial revert of D157837

This is a partial revert of https://reviews.llvm.org/D157837 - it turns
out that the LLVM test suite needs to be updated first not to use any of
the unsupported Flang options:
  * https://github.com/llvm/llvm-test-suite
Sample errors:
```
flang-new: error: unknown argument: '-fbounds-check'
flang-new: error: unknown argument: '-fcheck=all'
flang-new: error: unknown argument: '-fcheck-array-temporaries'
```

Once the test suite is updated, we can restore the reverted setting.

Broken bot:
  * https://lab.llvm.org/buildbot/#/builders/197/builds/9001

Differential Revision: https://reviews.llvm.org/D158289

Added: 
    

Modified: 
    clang/lib/Driver/Driver.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index adaad6760534e3..a3c21545c3a824 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -6494,8 +6494,8 @@ Driver::getOptionVisibilityMask(bool UseDriverMode) const {
     return llvm::opt::Visibility(options::CLOption);
   if (IsDXCMode())
     return llvm::opt::Visibility(options::DXCOption);
-  if (IsFlangMode()) {
-    return llvm::opt::Visibility(options::FlangOption);
+  if (IsFlangMode())  {
+    return llvm::opt::Visibility(options::ClangOption | options::FlangOption);
   }
   return llvm::opt::Visibility(options::ClangOption);
 }


        


More information about the cfe-commits mailing list