[PATCH] D158289: [flang][driver] Partial revert of https://reviews.llvm.org/D157837

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 08:43:03 PDT 2023


awarzynski created this revision.
awarzynski added reviewers: DavidSpickett, kiranchandramohan.
Herald added a reviewer: sscalpone.
Herald added a project: All.
awarzynski requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.

This is a partial revert of https://reviews.llvm.org/D157837 - it turns
out that the LLVM test suite needs to be updated first not to use any of
the unsupported Flang options:

- https://github.com/llvm/llvm-test-suite

Sample errors:

  flang-new: error: unknown argument: '-fbounds-check'
  flang-new: error: unknown argument: '-fcheck=all'
  flang-new: error: unknown argument: '-fcheck-array-temporaries'

Once the test suite is updated, we can restore the reverted setting.

Broken bot:

- https://lab.llvm.org/buildbot/#/builders/197/builds/9001


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158289

Files:
  clang/lib/Driver/Driver.cpp


Index: clang/lib/Driver/Driver.cpp
===================================================================
--- clang/lib/Driver/Driver.cpp
+++ clang/lib/Driver/Driver.cpp
@@ -6494,8 +6494,8 @@
     return llvm::opt::Visibility(options::CLOption);
   if (IsDXCMode())
     return llvm::opt::Visibility(options::DXCOption);
-  if (IsFlangMode()) {
-    return llvm::opt::Visibility(options::FlangOption);
+  if (IsFlangMode())  {
+    return llvm::opt::Visibility(options::ClangOption | options::FlangOption);
   }
   return llvm::opt::Visibility(options::ClangOption);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158289.551530.patch
Type: text/x-patch
Size: 567 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230818/20e163c4/attachment.bin>


More information about the cfe-commits mailing list