[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added inline comments.


================
Comment at: clang/lib/Parse/ParseTentative.cpp:94
+          // involve namespaces and friend declarations.
+          if (NextToken().is(tok::identifier))
+            return true;
----------------
I am wondering what is the false positive rate of this change? That is, if we enable incremental parsing by default (in a local build) and then run all tests which do not produce diagnostics. 


================
Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:74
+// expected-error at -1 2 {{'Inner' is a private member of 'PR13642'}}
+
 // Deduction guide
----------------
Could we move the diagnostic-producing cases in a separate file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157838/new/

https://reviews.llvm.org/D157838