[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 05:54:21 PDT 2023


aaron.ballman added a comment.

In D155627#4598032 <https://reviews.llvm.org/D155627#4598032>, @tbaeder wrote:

> In D155627#4596321 <https://reviews.llvm.org/D155627#4596321>, @aaron.ballman wrote:
>
>> In D155627#4595089 <https://reviews.llvm.org/D155627#4595089>, @tbaeder wrote:
>>
>>> Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 approved would make rebasing easier :)
>>
>> I can look into https://reviews.llvm.org/D144457, but then having to do https://reviews.llvm.org/D144457 right after is going to be tough. (I suspect there may be a copy pasta here.) ;-)
>
> But once you've reviewed https://reviews.llvm.org/D144457, reviewing https://reviews.llvm.org/D144457 shouldn't be that hard? :)

I dunno, I'm skeptical.

> I'm pretty sure the second link should've been https://reviews.llvm.org/D152132.

Oh, so now we're moving the goalposts too? ;-) I'll check that one out next, thanks for clarifying!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155627/new/

https://reviews.llvm.org/D155627



More information about the cfe-commits mailing list