[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 02:18:12 PDT 2023


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

In D149236#4597600 <https://reviews.llvm.org/D149236#4597600>, @nridge wrote:

> Adding Sam, since you're on a review roll ;)

back from vacation :-)



================
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:868
+  Argv.push_back(FullFilename);
+  auto Mangler = CommandMangler::forTests();
+  Mangler(Inputs.CompileCommand, FullFilename);
----------------
(the mangler isn't relevant here I think)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149236/new/

https://reviews.llvm.org/D149236



More information about the cfe-commits mailing list