[PATCH] D158248: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 17 22:18:14 PDT 2023
nridge created this revision.
nridge added reviewers: sammccall, hokein.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Plus bonus typo fix
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158248
Files:
clang-tools-extra/clangd/InlayHints.cpp
Index: clang-tools-extra/clangd/InlayHints.cpp
===================================================================
--- clang-tools-extra/clangd/InlayHints.cpp
+++ clang-tools-extra/clangd/InlayHints.cpp
@@ -273,7 +273,7 @@
return getSimpleName(E->getMember()).str();
}
std::string
- VisitDependentScopeMemberExpr(const DependentScopeDeclRefExpr *E) {
+ VisitDependentScopeDeclRefExpr(const DependentScopeDeclRefExpr *E) {
return getSimpleName(E->getDeclName()).str();
}
std::string VisitCXXFunctionalCastExpr(const CXXFunctionalCastExpr *E) {
@@ -509,7 +509,7 @@
// Do not show parameter hints for operator calls written using operator
// syntax or user-defined literals. (Among other reasons, the resulting
- // hints can look awkard, e.g. the expression can itself be a function
+ // hints can look awkward, e.g. the expression can itself be a function
// argument and then we'd get two hints side by side).
if (isa<CXXOperatorCallExpr>(E) || isa<UserDefinedLiteral>(E))
return true;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158248.551382.patch
Type: text/x-patch
Size: 1061 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230818/216247ed/attachment.bin>
More information about the cfe-commits
mailing list