[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D158137#4596948 <https://reviews.llvm.org/D158137#4596948>, @dexonsmith wrote:

> Can you explain the downside of leaving behind an alias?

Two minor ones. (a) Existing `-Wno-overriding-t-option` will not notice that they need to migrate and (b) Clang has accrued tiny tech debt.
If we eventually remove `-Wno-overriding-t-option` for tidiness, we will have to break `-Werror -Wno-overriding-t-option` users.

The difference is what error message we want to display:

  // no change to Options.td
  warning: unknown warning option '-Wno-overriding-t-option'; did you mean '-Wno-overriding-option'? [-Wunknown-warning-option]
  // def : Flag<["-"], "Wno-overriding-t-option">, Flags<[Ignored]>;
  warning: argument unused during compilation: '-Wno-overriding-t-option' [-Wunused-command-line-argument]

My understanding of `-Werror` users is that they may have to fix reasonable toolchain updates. Specifying `-Wno-overriding-t-option` for `-ffp-model=` and D41425 <https://reviews.llvm.org/D41425>.

https://gitlab.kitware.com/cmake/cmake/-/issues/20132 is probably the reason I don't want to touch `Darwin.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158137/new/

https://reviews.llvm.org/D158137