[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D158137#4596111 <https://reviews.llvm.org/D158137#4596111>, @MaskRay wrote:

> In D158137#4595927 <https://reviews.llvm.org/D158137#4595927>, @dexonsmith wrote:
>
>> This seems to drop `-Woverriding-t-option` entirely. Could that break builds if someone has (e.g.) `-Werror -Wno-overriding-t-option` in their build settings?
>
> Yes. We could also add an ignored `-Wno-overriding-t-option` to `Options.td`. Users who want to ignore the existing diagnostics need to add `-Wno-overriding-option` now.
> At some point we can add `clang_ignored_legacy_options_Group` to `-Wno-overriding-option` so that there will be a warning (error if `-Werror`)?

Even if we don't drop `-Woverriding-t-option`, as long as we make `-Woverriding-t-option` disconnected from the code we want to change (`-ffp-model=` related diagnostics), `-Werror` users will observe an error. It seems unavoidable for them to observe an error, unless we make `overriding-t-option` an alias for `overriding-option` (which we don't want to).

For non -Werror users, removing `-Woverriding-t-option` is not a problem. An unknown `-W` gives a warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158137/new/

https://reviews.llvm.org/D158137