[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

Ding Fei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 00:08:56 PDT 2023


danix800 added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836
+TEST_P(ASTImporterOptionSpecificTestBase,
+    ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) {
+  Decl *From, *To;
----------------
cor3ntin wrote:
> `ImportFunctionDeclBitShouldNotOverwriteCtorDeclBits`
I added the case into `DeclTest.cpp` because i think it can cover the root cause for both testcases.

How about remove the somewhat repeated one in `ASTImporterTest.cpp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158145/new/

https://reviews.llvm.org/D158145



More information about the cfe-commits mailing list