[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 16 23:59:00 PDT 2023
cor3ntin added a comment.
Thanks for working on this!
Looks good to me except for a couple typos.
Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github issue)
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836
+TEST_P(ASTImporterOptionSpecificTestBase,
+ ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) {
+ Decl *From, *To;
----------------
`ImportFunctionDeclBitShouldNotOverwriteCtorDeclBits`
================
Comment at: clang/unittests/AST/DeclTest.cpp:356
+TEST(Decl, FunctionDeclBitsShouldNotOverlappningWithCXXConstructorDeclBits) {
+ llvm::Annotations Code(R"(
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158145/new/
https://reviews.llvm.org/D158145
More information about the cfe-commits
mailing list