[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

Jianjian Guan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 19:52:57 PDT 2023


jacquesguan added a comment.

In D158045#4592331 <https://reviews.llvm.org/D158045#4592331>, @paulwalker-arm wrote:

> I'd hope there are common code paths where `isVLSTBuiltinType` would still be useful but I guess this step is required to make that happen anyway.
>
> If you permit a minor request can the new name please be `isSveVLSBuiltinType` to match the case used by the related `getSveEltType` function and the extra `T` in the old name has always bugged me.

Yes, I am working on a patch to implement clang vector language support for rvv just like we have on sve. Most part we could reuse `isVLSTBuiltinType` that contains VLST of both sve and rvv.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158045/new/

https://reviews.llvm.org/D158045



More information about the cfe-commits mailing list