[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:4
+// RUN:  | FileCheck --check-prefix=NOGATHER %s
+// RUN: %clangxx -c -mno-gather -### %s 2>&1 \
+// RUN:  | FileCheck --check-prefix=NOGATHER %s
----------------
Each RUN line makes testsuite execution slower and we should be careful adding more lines.

We don't generally additionally test `%clangxx` when `%clang` suffices. For non-linking, `%clang` is mostly identical to `%clangxx`.


================
Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:17
+// NOSCATTER: "-target-feature" "+prefer-no-scatter"
\ No newline at end of file

----------------
No newline at end of file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157680/new/

https://reviews.llvm.org/D157680