[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Han Shen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 15:54:35 PDT 2023


shenhan added a comment.

In D157750#4593582 <https://reviews.llvm.org/D157750#4593582>, @dhoekwater wrote:

> This patch will make it difficult to write tests for MFS on AArch64 before it is officially enabled. Currently, because clang performs the Triple check, we can use `-enable-split-machine-functions` to run tests with MFS on Arm, but after this patch the flag won't do anything. Is there a way that we can land this patch while still making MFS testable on AArch64?

Discussed with @dhoekwater offline, we decide to use a temporary hidden flag, something like "enable-mfs-for-debugging/testing", to force enable MFS for any triple during the period when MFS for arm is progressively rolled out, and when all is done, we will remove that temporary flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157750/new/

https://reviews.llvm.org/D157750



More information about the cfe-commits mailing list