[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 15:28:46 PDT 2023


smeenai added a comment.

In D141918#4577930 <https://reviews.llvm.org/D141918#4577930>, @jyknight wrote:

> In D141918#4566838 <https://reviews.llvm.org/D141918#4566838>, @smeenai wrote:
>
>> $ clang -std=c++20 -O2 -c crash.cpp
>> cannot use musttail with unwindabort
>
> Thanks for the report. We were missing a check of `CI.isUnwindAbort()` in CoroSplit.cpp's `shouldBeMustTail()` function -- fixed for next version of the series. (It's not a regression in tail-callability for coroutines, since that `call unwindabort` would've previously been an `invoke`, which also cannot be musttail'd.)

Just to confirm, this hasn't been uploaded yet, right? I wanted to try it out once it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141918/new/

https://reviews.llvm.org/D141918



More information about the cfe-commits mailing list