[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Han Shen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 11:57:07 PDT 2023


shenhan added inline comments.


================
Comment at: llvm/test/CodeGen/X86/mfs-triple.ll:8
+
+define void @foo4(i1 zeroext %0, i1 zeroext %1) nounwind {
+  br i1 %0, label %3, label %7
----------------
shenhan wrote:
> snehasish wrote:
> > Any reason why we can't use the bitcode already in test/CodeGen/machine-function-splitter.ll? (Going to be moved to test/Generic/machine-function-splitter.ll in D157563)
> > 
> > IMO we can just reuse the basic test and add these run and check lines.
> Moved the tests into machine-function-splitter.ll. Either this CL or D157563 can be submitted first, and the other will rebase on top of that.
Rebased on D157563.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157750/new/

https://reviews.llvm.org/D157750



More information about the cfe-commits mailing list