[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

Ian Anderson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 11:21:30 PDT 2023


iana marked an inline comment as done.
iana added a comment.

In D157757#4592766 <https://reviews.llvm.org/D157757#4592766>, @philnik wrote:

> I think these changes would allow us to drop the `stddef.h` compat header from libc++, which would be really nice.

I'd really rather not change how `nullptr_t` gets declared in this change, can we do these in another one?



================
Comment at: clang/lib/Headers/stddef.h:118-122
+#ifdef __cplusplus
+namespace std {
+typedef decltype(nullptr) nullptr_t;
+}
+using ::std::nullptr_t;
----------------
aaron.ballman wrote:
> Related:
> 
> https://github.com/llvm/llvm-project/issues/37564
> https://cplusplus.github.io/LWG/issue3484
> 
> CC @ldionne
I don't _think_ this change actually changes the way nullptr_t gets defined in C++, does it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157757/new/

https://reviews.llvm.org/D157757



More information about the cfe-commits mailing list