[PATCH] D157497: feat: Migrate isArch16Bit

Evgeniy Makarev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 16 08:46:39 PDT 2023


Pivnoy added a comment.

At the moment, the TargetParser architecture is extensible. This complicates the addition of new architectures, operating systems, and so on.
In the main discussion, it was proposed to redesign the architecture of this module in order to increase the possibility of adding new architectures, etc.
The main idea of   the rework was to separate the Triple entity into a data-class, and create a number of interfaces from components that would include Triple, through the implementation of which it would be possible to represent various data bindings of the components. At the moment, Triple is overflowing with various methods that do not fully meet the ideas of OOP.
Since the TargetParser module is quite large and has many dependencies throughout the llvm-project, it was first of all supposed to remove these methods from Triple, since they would not correspond to OOP ideas.
This would help to gradually rid Triple of unnecessary dependencies, and gradually change the architecture inside Triple, without breaking code of another LLVM developers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157497/new/

https://reviews.llvm.org/D157497



More information about the cfe-commits mailing list