[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

Wed Aug 16 05:03:59 PDT 2023

donat.nagy marked 2 inline comments as done.
donat.nagy added inline comments.

================
Comment at: clang/docs/analyzer/checkers.rst:81
+
+Ensure the shift operands are in proper range before shifting.
+
----------------
donat.nagy wrote:
> steakhal wrote:
> > We should exactly elaborate on what "proper" means here.
> What would you suggest? I could try to write a slightly longer suggestion, but I don't want to repeat the same conditions that I listed above the code example.
(I'm marking this request as "Done" because I couldn't find a better wording. Feel free to reopen the discussion if you wish.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156312/new/

https://reviews.llvm.org/D156312