[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

Tue Aug 15 20:14:33 PDT 2023

pengfei added a comment.

In D157297#4590692 <https://reviews.llvm.org/D157297#4590692>, @lygstate wrote:

> In D157297#4590580 <https://reviews.llvm.org/D157297#4590580>, @pengfei wrote:
>
>> 
>
>
>
>> I'd prefer macro to duplicated definitions. We have such precedents, e.g., https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994
>
> Do you means revert to the first version?

Yes.

>> Besides, you should update the summary as well.
>
> I don't know what kind of summary you want, I can give me that so I can update it

A reliable source about double colon operator cannot resolve function with parentheses in C++ is the best I expect, however I haven't find one so far.
Maybe a short description about the phenomenon on GCC/Clang is better than just giving error message. I don't have strong request for this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157297/new/

https://reviews.llvm.org/D157297