[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 14:16:46 PDT 2023


benlangmuir updated this revision to Diff 550474.
benlangmuir added a reviewer: vsapsai.
benlangmuir added a comment.

Add missing test updates: tests using the `Inputs/System/usr/include` should be using `-internal-isystem` to get the correct search path order with respect to the resource dir. The tests that were previously using `-isystem` were only working before because the other headers wrap their `#include_next` in `__has_include_next`, which was causing them to silently be missing these headers. With inttypes.h the include_next is unguarded, which revealed the issue.  Note: even if we someday add the has_include_next guard to inttypes.h the test change is still correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158021/new/

https://reviews.llvm.org/D158021

Files:
  clang/lib/Lex/ModuleMap.cpp
  clang/test/Modules/Inputs/System/usr/include/module.map
  clang/test/Modules/Werror-Wsystem-headers.m
  clang/test/Modules/crash-vfs-include-pch.m
  clang/test/Modules/cstd.m
  clang/test/Modules/pch-used.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158021.550474.patch
Type: text/x-patch
Size: 5005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230815/e4ac4341/attachment.bin>


More information about the cfe-commits mailing list