[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

Takuya Shimizu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 11:13:50 PDT 2023


hazohelet updated this revision to Diff 550403.
hazohelet marked 16 inline comments as done.
hazohelet added a comment.

Address some review comments

- Renamed `ConvertCharToString` to `WriteCharValueForDiagnostic`
- Made the function static
- Fixed the printing for unicode 0x80 ~ 0xFF
- Added decimal value next to the hex code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/Lexer/cxx1z-trigraphs.cpp
  clang/test/SemaCXX/static-assert-cxx26.cpp
  clang/test/SemaCXX/static-assert.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155610.550403.patch
Type: text/x-patch
Size: 10713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230815/97af2fbc/attachment.bin>


More information about the cfe-commits mailing list