[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

Ian Anderson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 10:17:43 PDT 2023


iana added a comment.

In D157793#4588909 <https://reviews.llvm.org/D157793#4588909>, @jyknight wrote:

> I'm a bit confused by this change vs its description.
>
> It looks like stdarg already supported `__need___va_list`, which is what you said Apple needs. Does Apple //also// require the other __need_va_copy/etc, too? If not, why add support for them? (I think we should prefer not to add support for pieces that are not actually needed)

That name is misleading, `__need___va_list` gives you `__gnuc_va_list` and not `va_list`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157793/new/

https://reviews.llvm.org/D157793



More information about the cfe-commits mailing list