[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 04:23:31 PDT 2023


aaron.ballman added a comment.

In D156537#4587832 <https://reviews.llvm.org/D156537#4587832>, @v.g.vassilev wrote:

> @Hahnfeld, let's move forward and rely on a post-commit review here if necessary.

Because one of the codegen code owners has been active on the thread with concerns, I think it's better to wait a bit longer for an explicit sign-off that those concerns are addressed (this code impacts more than clang-repl).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156537/new/

https://reviews.llvm.org/D156537



More information about the cfe-commits mailing list