[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6073
 
+  if (auto A = Target.getAs<AttributedTypeLoc>()) {
+    Target = A.getModifiedLoc();
----------------
By unwrapping these in a fixed order, we'll successfully unwrap a pointer to an attributed function type, but not an attributed pointer to function type.

Maybe extract a recursive function so we can unwrap arbitrary sequences of sugar?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157952/new/

https://reviews.llvm.org/D157952