[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 00:56:33 PDT 2023


balazske added a comment.

When committing this patch, the commit message should not contain the whole AST and crash dump (phabricator takes the "summary" text), this looks too much in a commit message. One AST dump from the wrong To AST is enough.



================
Comment at: clang/test/Import/templated-friend/test.cpp:5
+  A<int> a;
+}
----------------
These test files are really not needed. The same AST import is performed in the unit test.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5644
+    )",
+                                       Lang_CXX03, "", Lang_CXX03, "X");
+
----------------
This formatting looks not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157691/new/

https://reviews.llvm.org/D157691



More information about the cfe-commits mailing list